Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ToA Potion Deposit #6625

Closed
wants to merge 4 commits into from
Closed

Create ToA Potion Deposit #6625

wants to merge 4 commits into from

Conversation

ealahd
Copy link

@ealahd ealahd commented Sep 20, 2024

Prevents players from using items on other players in ToA nexus room since clicking potions on other players often causes annoyance.

@runelite-github-app
Copy link

runelite-github-app bot commented Sep 20, 2024

@geheur
Copy link
Contributor

geheur commented Sep 27, 2024

Does this actually work?
the menu is rebuilt 30 times per game tick. this sounds like it has a 1/30 chance of working.

@ealahd
Copy link
Author

ealahd commented Sep 27, 2024

Not really too familiar with the API and just salvaged the code from an already approved plugin. Worked in testing but the testing included going into the nexus room with alt and main a few times. I can test further to see if you have a point.

edit: Changed it into client tick which I think should work better if I understood it correctly.

@MESLewis
Copy link
Member

MESLewis commented Oct 2, 2024

There is already a comprehensive toa plugin that this feature could be added to. I suggest contacting @LlemonDuck to get this feature added to the existing plugin.

@LlemonDuck
Copy link
Contributor

I would gladly welcome this as a feature in the Tombs of Amascut plugin, and may add it regardless. Would you be interested in PRing it instead of creating a whole new plugin for users to find and install?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 15, 2024
@ealahd
Copy link
Author

ealahd commented Oct 16, 2024

Yeah absolutely would be better not to have it as a separate plugin. I can PR or you can implement it yourself whichever you prefer. I don't really know what I am doing so it might be better you just add it yourself.

@LlemonDuck LlemonDuck removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 19, 2024
@LlemonDuck
Copy link
Contributor

Thanks, will do. I'll ping you in the corresponding ToA plugin PR soon as an FYI.

@LlemonDuck LlemonDuck closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants