feat(atlantis): add containerPort custom #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullianow
force-pushed
the
containerport-custom
branch
3 times, most recently
from
4e9ac05 to
14ee0f8
Compare
Signed-off-by: Julliano Goncalves <[email protected]>
jullianow
force-pushed
the
containerport-custom
branch
from
14ee0f8 to
f8a8caa
Compare
There was a problem hiding this comment.
Hi @jullianow, thank you for your contrubtion.
Please check the comment below and also:
- bump chart minor version due to new feature
- update the comment to reflect the new feature
-- (int) [optional] Define the port you would like atlantis to run on. Defaults to 4141.
GMartinez-Sisti
added
the
waiting-on-response
jullianow
force-pushed
the
containerport-custom
branch
from
f537c79 to
6f38d76
Compare
Signed-off-by: Julliano Goncalves <[email protected]>
jullianow
force-pushed
the
containerport-custom
branch
from
6f38d76 to
7548d87
Compare
| @@ -172,13 +172,16 @@ serviceAccountSecrets: {} | |||
| # Default values for atlantis (override as needed). | |||
| ## -------------------------- ## | |||
|
|
|||
| # -- (int) [optional] Define the port you would like atlantis to run on. Defaults to 4141. | |||
There was a problem hiding this comment.
Suggested change
| # -- (int) [optional] Define the port you would like atlantis to run on. Defaults to 4141. | |
| # -- (int) [optional] Define the port you would like atlantis to run on. When 0, the value of service.targetPort is used. |
| @@ -267,6 +267,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "containerPort": { | |||
There was a problem hiding this comment.
Type needs to be integer alone with default as 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This change seeks to provide the possibility of defining a port for the container different from the one specified in the service.
why
This change aims to maintain compatibility with scenarios in which the Atlantis administrator wants to deploy a sidecar (using the extraContainers property) in which it will receive the traffic coming from the Service. This is a case, for example, when we want to have an oauth2-proxy responding to requests and acting as a proxy for Atlantis. With this change, this will still be possible for those who need it. By default, the behavior continues to be that the Service's targetPort is the same value for the Atlantis ContainerPort.