Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZCP Managed Index & Milvus Index demos #13170

Merged
merged 1 commit into from May 10, 2024

Conversation

jaelgu
Copy link
Contributor

@jaelgu jaelgu commented Apr 30, 2024

Description

Update demos for ZCP managed index & Milvus index:

  • ZCP managed index: update notebook to adapt recent changes in llama-index structure.
  • Milvus index: update notebook & docstring to support Milvus local (using a local directory as vector storage).

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 30, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have to use llama-index-legacy at all here

This import works fine
from llama_index.core.vector_stores import MetadataFilters, ExactMatchFilter

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 6, 2024
@jaelgu
Copy link
Contributor Author

jaelgu commented May 6, 2024

We shouldn't have to use llama-index-legacy at all here

This import works fine from llama_index.core.vector_stores import MetadataFilters, ExactMatchFilter

@logan-markewich Thank you for comments. I've updated the notebook.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 10, 2024
@logan-markewich logan-markewich merged commit cfc165d into run-llama:main May 10, 2024
8 checks passed
raghavdixit99 pushed a commit to raghavdixit99/llama_index_lance that referenced this pull request May 11, 2024
@jaelgu jaelgu deleted the update-milvus branch May 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants