Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error ignoring during streaming #13160

Merged
merged 2 commits into from Apr 30, 2024
Merged

Conversation

logan-markewich
Copy link
Collaborator

This option wasn't being used anywhere, and was mostly just hiding actual errors.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 29, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 29, 2024
@logan-markewich logan-markewich merged commit c5a49e0 into main Apr 30, 2024
8 checks passed
@logan-markewich logan-markewich deleted the logan/raise_error_stream branch April 30, 2024 15:31
JuHyung-Son pushed a commit to UpstageAI/llama_index that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants