Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error when parse file using SimpleFileNodeParser and file's extension doesn't in FILE_NODE_PARSERS #13156

Merged
merged 6 commits into from Apr 30, 2024

Conversation

yukikwi
Copy link
Contributor

@yukikwi yukikwi commented Apr 29, 2024

Description

This PR is a patch for issue #13152 .
The problem is currently, if file extension is unsupported. It will add document to list of nodes that make code crash

Fixes # (issue)
#13152

New Package?

N/A

Version Bump?

N/A

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 29, 2024 16:09
auto-merge was automatically disabled April 30, 2024 02:00

Head branch was pushed to by a user without write access

@yukikwi
Copy link
Contributor Author

yukikwi commented Apr 30, 2024

@logan-markewich I removed metadata check from unittest because code under SimpleFileNodeParser class doesn't add extra metadata to documents / nodes

@logan-markewich logan-markewich enabled auto-merge (squash) April 30, 2024 18:42
@logan-markewich logan-markewich merged commit 3bce56d into run-llama:main Apr 30, 2024
8 checks passed
JuHyung-Son pushed a commit to UpstageAI/llama_index that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants