core: Always fire KeyPress after KeyDown for buttons
#16245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
button-events-order
branch
2 times, most recently
from
1e33e7e
to
d495724
Compare
Dinnerbone
approved these changes
May 8, 2024
Dinnerbone
approved these changes
May 9, 2024
This test ensures that button key press events take precedence over text input.
Button events are actually handled twofold: 1. KeyPress for printable characters is handled on TextInput, 2. KeyPress for special characters (e.g. enter, arrows) is handled on KeyDown. Before this patch, KeyPress was fired too early, so that for special characters (2) it fired BEFORE KeyDown. This was not a problem for printable characters, as they fired on TextInput, which always fired separately after KeyDown. This patch ensures that KeyPress is fired always in the proper order.
This test verifies the behavior of button events when special characters are pressed.
Dinnerbone
force-pushed
the
button-events-order
branch
from
d495724
to
8ba344a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing a bug I found when writing some tests.
Button events are actually handled twofold:
KeyPressfor printable characters is handled onTextInput,KeyPressfor special characters (e.g. enter, arrows) is handled onKeyDown.Before this patch,
KeyPresswas fired too early, so that for special characters (2) it fired BEFOREKeyDown. This was not a problem for printable characters, as they fired onTextInput, which always fired separately afterKeyDown.This patch ensures that
KeyPressis fired always in the proper order.Additionally I added a test that verifies the "KeyPress events take precedence over text input" behavior, because it was not covered by tests before.