Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shipit-engine and rails #281

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2024

Bumps shipit-engine and rails. These dependencies needed to be updated together.
Updates shipit-engine from 0.38.0 to 0.39.0

Release notes

Sourced from shipit-engine's releases.

v0.39.0

What's Changed

New Contributors

Full Changelog: Shopify/shipit-engine@v0.38.0...v0.39.0

Changelog

Sourced from shipit-engine's changelog.

0.39.0

  • Minimum Ruby version is now Ruby 3.0
  • Upgraded to Rails 7.1.1
  • Upgraded Octokit to 5.6.1 (#1327)
  • Migrate from legacy Rails secrets to credentials (#1326)
  • For deployments, allow_concurrency defaults to the same value as force. If wanted, it can be set separately by passing the intended value for allow_concurrency to build_deploy method
Commits

Updates rails from 7.0.8.4 to 7.1.3.4

Release notes

Sourced from rails's releases.

7.1.3.4

Active Support

  • No changes.

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • No changes.

Action Pack

  • Include the HTTP Permissions-Policy on non-HTML Content-Types [CVE-2024-28103]

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.

... (truncated)

Commits
  • 19eebf6 Preparing for 7.1.3.4 release
  • bd7c28a update changelog
  • 1ac6d40 Sanitize ActionText HTML ContentAttachment in Trix edit view
  • c7b9e0c include the HTTP Permissions-Policy on non-HTML Content-Types
  • 747a03b Preparing for 7.1.3.3 release
  • 260cb39 Upgrade Trix to 2.1.1 to fix [CVE-2024-34341][1]
  • 6f0d1ad Preparing for 7.1.3.2 release
  • c25f0fc Respect raise_on_missing_ in controller
  • d73ed95 Preparing for 7.1.3.1 release
  • 43037d8 update changelog
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 5, 2024
dependabot bot and others added 2 commits October 31, 2024 18:20
Bumps [shipit-engine](https://github.com/shopify/shipit-engine) and [rails](https://github.com/rails/rails). These dependencies needed to be updated together.

Updates `shipit-engine` from 0.38.0 to 0.39.0
- [Release notes](https://github.com/shopify/shipit-engine/releases)
- [Changelog](https://github.com/Shopify/shipit-engine/blob/main/CHANGELOG.md)
- [Commits](Shopify/shipit-engine@v0.38.0...v0.39.0)

Updates `rails` from 7.0.8.4 to 7.1.3.4
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.0.8.4...v7.1.3.4)

---
updated-dependencies:
- dependency-name: shipit-engine
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@simi simi force-pushed the dependabot/bundler/multi-64d6d51a5d branch from a6b8c2f to cc75035 Compare October 31, 2024 17:21
- there are no sensitive info, no need to encrypt
@simi simi force-pushed the dependabot/bundler/multi-64d6d51a5d branch from cc75035 to 877fc31 Compare October 31, 2024 17:21
@simi
Copy link
Member

simi commented Oct 31, 2024

@segiddins seems shipit migrated to Rails.application.credentials, but in our case secrets seems enough and "redirection" to secrets.yml seems work as intended.

@simi simi requested a review from segiddins October 31, 2024 17:26
@simi simi merged commit b36bee4 into master Oct 31, 2024
2 checks passed
@simi simi deleted the dependabot/bundler/multi-64d6d51a5d branch October 31, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants