Improve default gem handling by treating default gems as any other gem #7673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/treat-default-gems-as-regular-gems
branch
4 times, most recently
from
a672c88
to
a4909e9
Compare
For backwards compatibility, make sure default gems are still used as a last resort when materializing, in case no remote, cached, or installed specs are found.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/treat-default-gems-as-regular-gems
branch
from
a4909e9
to
93788f6
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/treat-default-gems-as-regular-gems
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 12, 2024
…-gems-as-regular-gems Improve default gem handling by treating default gems as any other gem (cherry picked from commit 11451bc)
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 12, 2024
…-gems-as-regular-gems Improve default gem handling by treating default gems as any other gem (cherry picked from commit 11451bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Bundler behaves inconsistently in presence of default gems, and that can be confusing. See for example the situation in ruby/ruby#9163 (comment).
What is your fix for the problem, implemented in this PR?
My fix is that, once a default gem is specified directly in the Gemfile, or resolved as a transitive dependency, it becomes part of the bundle and gets treated as a "regular gem", so it's cached, explicitly installed in the configured location, etc.
NOTE: This is an improved version of #7242 (which had to be reverted) which fixes the issues in the initial approach and makes the change fully backwards compatible. If at
bundler/setuptime, default gems are found to be missing in the installed location, we will still fallback to considering them, but by defaultbundle installwill treat them as regular gems and install them normally.I think the new approach should also fix #4088.
Make sure the following tasks are checked