Add useful error message for plugin load

[sarahsehr]

What was the end-user or developer problem that led to this PR?

When starting to work on my first issue, I found that rake setup failed for me. This was due to having previously installed a plugin, whose files had since been deleted (presumably when I uninstalled that version of Ruby).

Fixes #7636.

What is your fix for the problem, implemented in this PR?

Check to see whether each load path for the plugin is a directory. If it is not, notify the user in a friendly message which plugin in the problem and how to resolve the issue.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[simi]

Hello @sarahsehr. Code looks good, but some specs are failing, which seems not really related to your change, since I can see the same failure on main branch. I'm looking into. 👀

EDIT: false alarm, main branch looks ok, it was outdated tmp during my initial test.

[simi]

Have you considered just warn in here and skip plugin + continue? 🤔

[simi]

@sarahsehr this seems to fails the test (and breaks some test gem installation at the same time). add_to_load_path is defined at

rubygems/lib/rubygems.rb

Lines 576 to 584 in c1933bf

	##
	# Add a list of paths to the $LOAD_PATH at the proper place.
	def self.add_to_load_path(*paths)
	@activated_gem_paths = activated_gem_paths + paths.size
	# gem directories must come after -I and ENV['RUBYLIB']
	$LOAD_PATH.insert(Gem.load_path_insert_index, *paths)
	end

and it expects multiple arguments. To achieve this by passing paths array, you need to add splat (*) operator. Changing this to Gem.add_to_load_path(*paths) should fix this. 🙏

[deivid-rodriguez]

Since this a bundle install run after all, should we automatically reinstall any missing plugins if necessary, instead of erroring out?

[simi]

@sarahsehr friendly ping, is there still interest to finish this? Happy to help or take over to fix the one blocking comment in plugin.rb.

[sarahsehr]

@sarahsehr friendly ping, is there still interest to finish this? Happy to help or take over to fix the one blocking comment in plugin.rb.

Thanks for the friendly ping! Coincidentally, I was planning to work on this today. :)

[deivid-rodriguez]

We're almost done with a big rework of how plugins currently work at #6957, I wonder if that could actually fix/improve this problem.

[sarahsehr]

We're almost done with a big rework of how plugins currently work at #6957, I wonder if that could actually fix/improve this problem.

Thanks for pointing this out! I pulled the branch from that PR and was able to reproduce the issue, so unfortunately it doesn't.

[sarahsehr]

@simi I have changed the output to warning and continue the install. The output looks like above (ignore the black line, that's debug output from another gem).

[deivid-rodriguez]

If there are two non existing paths in the same plugin, we'll end up printing this big error block twice. I think it will read slightly better to find all invalid paths first, and then print an error including all of them. Like

      paths = index.load_paths(name)
      invalid_paths = paths.reject {|p| File.directory?(p) }

      if invalid_paths.any?
        Bundler.ui.warn <<~MESSAGE
          The following plugin paths don't exist: #{invalid_paths.join(", ")}.

          This can happen if the plugin was installed with a different version of Ruby that has since been uninstalled.

          If you would like to reinstall the plugin, run:
          
          bundler plugin uninstall #{name} && bundler plugin install #{name}

          Continuing without installing plugin #{name}.
        MESSAGE

        return
      end

      Gem.add_to_load_path(*paths)

[sarahsehr]

Ya, I agree that makes sense. I updated code/test. This is what it looks like now after running rake setup: