Fix some flaky test failures on Windows #7453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
There's a longstanding flaky CI failure on Windows that reads like this:
See for example https://github.com/rubygems/rubygems/actions/runs/9663003543/job/26654152938.
What is your fix for the problem, implemented in this PR?
My diagnosis is that when starting the parallelized test suite, multiple processes copy source files necessary to build bundler to its own folder in
tmp/
. On Windows, this can apparently result in permission errors, I guess because the file is in use by another process.As a workaround, I changed building bundler in CI to happen just once at
bin/rake spec:deps
time, not on the fly when running specs.I expect this to make this error not happen again.
Make sure the following tasks are checked