Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against SSRF attacks in link verification #5076

Merged

Conversation

segiddins
Copy link
Member

Uses bhuga/faraday-restrict-ip-addresses#16

Signed-off-by: Samuel Giddins [email protected]

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03%. Comparing base (4ae91b5) to head (7a4f5b7).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5076   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         421      421           
  Lines        8776     8777    +1     
=======================================
+ Hits         8516     8517    +1     
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins marked this pull request as ready for review September 26, 2024 14:50
@simi
Copy link
Member

simi commented Sep 30, 2024

Seems release is going to happen soon 🙏.

@segiddins segiddins force-pushed the segiddins/guard-against-ssrf-attacks-in-link-verification branch from 2c52355 to 8e05e54 Compare September 30, 2024 19:27
@segiddins segiddins requested a review from simi September 30, 2024 19:27
@simi simi force-pushed the segiddins/guard-against-ssrf-attacks-in-link-verification branch from 8e05e54 to ea62255 Compare September 30, 2024 19:35
@segiddins segiddins force-pushed the segiddins/guard-against-ssrf-attacks-in-link-verification branch from ea62255 to 7a4f5b7 Compare September 30, 2024 19:41
@segiddins segiddins enabled auto-merge (squash) September 30, 2024 19:54
@segiddins segiddins merged commit 12a7ab8 into master Sep 30, 2024
18 checks passed
@segiddins segiddins deleted the segiddins/guard-against-ssrf-attacks-in-link-verification branch September 30, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants