Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length validations for user-supplied string attributes #5056

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Sep 20, 2024

To help avoid users adding a large amount of unexpected data to the pages we render

Signed-off-by: Samuel Giddins [email protected]

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (7772233) to head (cb88db5).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5056      +/-   ##
==========================================
- Coverage   97.02%   97.02%   -0.01%     
==========================================
  Files         421      421              
  Lines        8754     8749       -5     
==========================================
- Hits         8494     8489       -5     
  Misses        260      260              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins force-pushed the segiddins/add-length-validations-for-user-supplied-string-attributes branch from 6344df9 to cb88db5 Compare September 23, 2024 18:49
@segiddins segiddins marked this pull request as ready for review September 23, 2024 22:06
@simi simi merged commit bd5a7f3 into master Sep 30, 2024
18 checks passed
@simi simi deleted the segiddins/add-length-validations-for-user-supplied-string-attributes branch September 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants