Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Honeybadger & Datadog in local environments #5035

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

colby-swandale
Copy link
Member

What's this about?

We use Honeybadger and Datadog to help maintain our service in production. Currently, these gems are enabled in production even though local development environment's are not setup/authenticated to these services.

What does this Pull Request change?

This Pull Request disables Honeybadger and Datadog (and more?) from being initialized in local environments

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (84c2f36) to head (3b66537).
Report is 42 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5035   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files         420      421    +1     
  Lines        8726     8752   +26     
=======================================
+ Hits         8466     8492   +26     
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi
Copy link
Member

simi commented Sep 17, 2024

Would it be possible to disable it also on Gemfile level (skip those in development/test env)?

config/initializers/datadog.rb Outdated Show resolved Hide resolved
@colby-swandale
Copy link
Member Author

colby-swandale commented Sep 24, 2024

Would it be possible to disable it also on Gemfile level (skip those in development/test env)?

I would prefer we load the gems so we can catch any load errors before it reaches production, and the CPU/memory cost is fairly minimal.

@simi
Copy link
Member

simi commented Sep 24, 2024

Would it be possible to disable it also on Gemfile level (skip those in development/test env)?

I would prefer we load the gems so we can catch any load errors before it reaches production, and the CPU/memory cost is fairly minimal.

My concern by loading those gems locally is they are basically "friendly spyware", which is not really friendly to developers since it can leak some data from local computer if there is any mistake. But good to go with this. It is much better than originally already.

@segiddins segiddins merged commit 49db490 into master Sep 24, 2024
17 of 18 checks passed
@segiddins segiddins deleted the colby/disable-services branch September 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants