Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pluralize "version(s) since" on versions index page #4466

Merged
merged 1 commit into from
Feb 19, 2024

Commits on Feb 19, 2024

  1. Correctly pluralize "version(s) since" on versions index page

    From rubygems#4460 (comment)
    
    Added a test to verify this string is being pluralized properly.
    
    Also added every locale with varying degrees of confidence
    - es/pt-BR: I know enough to be fairly confident this is correct
    - ja: I know enough to be fairly confident this is correct and verified
      with native speaker
    - fr: I verified with native speaker
    - de/nl: I used online translation tools to check singular vs plural
    - zh-CN/zh-TW: I don't think they pluralize, but I just copied the
      existing string into both `other` and `one` which maintains behavior
      before this PR anyway.
    albertchae committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e638006 View commit details
    Browse the repository at this point in the history