Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh-TW translation #4092

Merged
merged 12 commits into from
May 31, 2024
Merged

update zh-TW translation #4092

merged 12 commits into from
May 31, 2024

Conversation

5idereal
Copy link
Contributor

No description provided.

@simi
Copy link
Member

simi commented Sep 27, 2023

Hello and thanks for the pull request.

@adrianthedev Would it make sense to contribute avo translation into https://github.com/avo-hq/avo/tree/main/lib/generators/avo/templates/locales?

@khiav223577 @JuanitoFatas @hrs113355 any chance to review?

config/locales/zh-TW.yml Outdated Show resolved Hide resolved
config/locales/zh-TW.yml Outdated Show resolved Hide resolved
config/locales/zh-TW.yml Outdated Show resolved Hide resolved
@khiav223577
Copy link
Contributor

Others LGTM

@simi
Copy link
Member

simi commented Sep 29, 2023

@5idereal can you please check on suggested changes?

@5idereal
Copy link
Contributor Author

5idereal commented Oct 1, 2023

Hi @simi, I've committed all the suggestions from @khiav223577.

@khiav223577 感謝您的 review!

@simi
Copy link
Member

simi commented Oct 1, 2023

Thanks! There were also some troubles on CI due to formatting, let's wait for other CI round.

@adrianthedev
Copy link
Contributor

Yes @simi. That would be great to have it in Avo.
Thank you!

@simi
Copy link
Member

simi commented Oct 31, 2023

@5idereal sorry for the delay on this PR, can you please rebase? I'm happy to merge once done.

@5idereal
Copy link
Contributor Author

5idereal commented Nov 1, 2023

@simi should be ready for merge. can you check it again please?

@simi
Copy link
Member

simi commented Dec 30, 2023

@5idereal sorry for long delay :( Any chance to rebase this for final time please?

@simi
Copy link
Member

simi commented May 31, 2024

ℹ️ I tried to rebase on my own 🙏

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (d4e8926) to head (8c8ec04).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4092      +/-   ##
==========================================
- Coverage   97.12%   95.94%   -1.18%     
==========================================
  Files         393      393              
  Lines        8319     8319              
==========================================
- Hits         8080     7982      -98     
- Misses        239      337      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi simi merged commit af87334 into rubygems:master May 31, 2024
15 checks passed
@simi
Copy link
Member

simi commented May 31, 2024

Thanks anyone involved in here and sorry for the delay. I have fixed small problems with keys, rebased and finally merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants