-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update zh-TW translation #4092
update zh-TW translation #4092
Conversation
Hello and thanks for the pull request. @adrianthedev Would it make sense to contribute avo translation into https://github.com/avo-hq/avo/tree/main/lib/generators/avo/templates/locales? @khiav223577 @JuanitoFatas @hrs113355 any chance to review? |
Others LGTM |
@5idereal can you please check on suggested changes? |
Co-authored-by: Rumble Huang <[email protected]>
Co-authored-by: Rumble Huang <[email protected]>
Co-authored-by: Rumble Huang <[email protected]>
Hi @simi, I've committed all the suggestions from @khiav223577. @khiav223577 感謝您的 review! |
Thanks! There were also some troubles on CI due to formatting, let's wait for other CI round. |
Yes @simi. That would be great to have it in Avo. |
Co-authored-by: Rumble Huang <[email protected]>
@5idereal sorry for the delay on this PR, can you please rebase? I'm happy to merge once done. |
@simi should be ready for merge. can you check it again please? |
@5idereal sorry for long delay :( Any chance to rebase this for final time please? |
ℹ️ I tried to rebase on my own 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4092 +/- ##
==========================================
- Coverage 97.12% 95.94% -1.18%
==========================================
Files 393 393
Lines 8319 8319
==========================================
- Hits 8080 7982 -98
- Misses 239 337 +98 ☔ View full report in Codecov by Sentry. |
Thanks anyone involved in here and sorry for the delay. I have fixed small problems with keys, rebased and finally merged. |
No description provided.