Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add mastodon handles to profile #3321

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zzak
Copy link

@zzak zzak commented Jan 3, 2023

No description provided.

@zzak zzak marked this pull request as draft January 3, 2023 04:08
)
%>

<%= mastodon_handle(user) %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible to generate link using mastodon handle? 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simi I wasn't able to find a way to do this, it's also weird if we just let anyone put any link they want on the profile? We probably have to sanitize it, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't enough to just split on last @ and reverse join with / (and prepending https protocol)?

@simi
Copy link
Member

simi commented Apr 23, 2023

@zzak ad mastodon handle it seems I was right according to docs. The only unknown part is the protocol (http/https), but we can make it into note we support only secured HTTPS servers.

Would you like to continue on this? Alternatively just ping me and I can do my best to finish this feature.

@zzak
Copy link
Author

zzak commented Apr 28, 2023

@simi Thanks for the ping, have been busy with other stuff but I may pick this back up. This also seems like a really good bite-sized feature for an early contributor, happy to hand it over in that case!

@segiddins
Copy link
Member

See rubygems/rfcs#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants