Mailer: Email to remind maintainers of gems with 180M+ downloads to enable MFA #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettymakes
force-pushed
the
mfa-mailer-reminder-one-week
branch
4 times, most recently
from
1c81217
to
3bfe9c2
Compare
bettymakes
commented
Aug 4, 2022
| users.each do |user| | ||
| Mailer.delay.mfa_required_soon_announcement(user.id) if mx_exists?(user.email) | ||
| i += 1 | ||
| print format("\r%.2f%% (%d/%d) complete", i.to_f / total_users * 100.0, i, total_users) |
There was a problem hiding this comment.
Do we want to count and report failures?
There was a problem hiding this comment.
Good point. It wouldn't hurt if we did. I think the value of counting and reporting failures is if we expect someone will do something with that information. I'd defer this to whoever will be running the task, if they'd want to action on that info.
jenshenny
reviewed
Aug 4, 2022
bettymakes
force-pushed
the
mfa-mailer-reminder-one-week
branch
2 times, most recently
from
5b5f402
to
9d5901f
Compare
bettymakes
commented
Aug 5, 2022
bettymakes
force-pushed
the
mfa-mailer-reminder-one-week
branch
3 times, most recently
from
6d86cc9
to
dd0d59f
Compare
bettymakes
force-pushed
the
mfa-mailer-reminder-one-week
branch
2 times, most recently
from
e972c08
to
19160d4
Compare
jenshenny
approved these changes
Aug 8, 2022
jenshenny
reviewed
Aug 8, 2022
Per Rails Guides (https://guides.rubyonrails.org/v6.1/testing.html\#the-basic-test-case), inheriting from ActionMailer::TestCase will automatically reset the ActionMailer::Base.deliveries array.
bettymakes
force-pushed
the
mfa-mailer-reminder-one-week
branch
2 times, most recently
from
05cb8b1
to
6d263bb
Compare
|
@sonalkr132 The mailer is good to go for tomorrow 👍. |
Subject line and heading should be relevant to the user. For users who have MFA enabled, but simply need to stregnthen the mfa level, the copy of 'Enable MFA' is an inaccurate call to action. Therefore, the copy has been revised to better reflect an accurate CTA.
bettymakes
force-pushed
the
mfa-mailer-reminder-one-week
branch
from
6d263bb
to
63072d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤷♀️ What problem are you solving?
Contributes to https://github.com/Shopify/ruby-conventions/issues/134
Closes #3164
We need to send out a reminder email on August 8, 2022 to remind maintainers of gems with 180M+ downloads to enable MFA. This mailer is crafted with a targeted approach. It's only being sent to those impacted maintainers who have yet to enable MFA (
disabled), or have weak MFA enabled (ui_only).📋 How will you solve this?
🔹 Create a mailer
mfa_required_soon_announcementand a mailer view in bothHTMLandplain textformatsdisabled)ui_only)🔹 Add rake task for delivering the email
rake mfa_policy:reminder_enable_mfa🔹 Set up mailer preview
🎩 Tophat instructions
Below are the instructions for trying this out yourself:
📧 To preview the email:
rails s) ...http://localhost:3000/rails/mailers) to review the list of all mailers available for previewmfa_required_soon_announcementhttp://localhost:3000/rails/mailers/mailer/mfa_required_soon_announcement👤 To change the user:
MailerPreview#mfa_required_soon_announcement.User.last.idwith a different user (e.g.User.first)👀 Email versions
🚫 Email for users with MFA disabled
🤞 Email for users with MFA enabled (
ui_only) -- weak MFA