Skip to content

Commit

Permalink
Clean up not using mfa * text
Browse files Browse the repository at this point in the history
  • Loading branch information
martinemde committed Aug 31, 2024
1 parent e8c4b09 commit 1d13ba7
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 31 deletions.
8 changes: 1 addition & 7 deletions app/helpers/rubygems_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,7 @@ def link_to_owner(owner, show_mfa_status: false)
link_text = avatar(32, "gravatar-#{owner.id}", owner, class: "tw-rounded-full tw-mr-1")
link_text << " #{owner.display_handle}"
link_text << " *" if show_mfa_status && owner.mfa_disabled?
link_to(
link_text.html_safe,
profile_path(owner.display_id),
alt: owner.display_handle,
title: owner.display_handle,
class: "t-link tw-flex tw-items-center"
)
link_to(link_text.html_safe, profile_path(owner.display_id), class: "t-link tw-flex tw-items-center")
end

def link_to_user(user)
Expand Down
2 changes: 1 addition & 1 deletion app/views/rubygems/_gem_members.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<% if show_mfa_status %>
<% if rubygem.owners.without_mfa.present? %>
<span class="tw-my-2 gem__users__mfa-text mfa-warn">
<%= current_user.mfa_disabled? ? t(".self_no_mfa_warning_html") : t(".not_using_mfa_warning_show") %>
<%= current_user.mfa_disabled? ? t(".self_no_mfa_warning_html") : t(".not_using_mfa_warning") %>
</span>
<% else %>
<span class="gem__users__mfa-text mfa-info"><%= t '.using_mfa_info' %></span>
Expand Down
3 changes: 1 addition & 2 deletions config/locales/de.yml
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,7 @@ de:
gem_members:
authors_header: Autoren
self_no_mfa_warning_html:
not_using_mfa_warning_show:
not_using_mfa_warning_hide:
not_using_mfa_warning:
owners_header: Besitzer
pushed_by:
using_mfa_info:
Expand Down
5 changes: 2 additions & 3 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -673,11 +673,10 @@ en:
gem_members:
authors_header: Authors
self_no_mfa_warning_html: Please consider <a href="/settings/edit">enabling multi-factor authentication (MFA)</a> to keep your account secure.
not_using_mfa_warning_show: "* Some owners are not using multi-factor authentication (MFA). Click for the complete list."
not_using_mfa_warning_hide: "* The following owners are not using multi-factor authentication (MFA). Click to hide."
not_using_mfa_warning: "* Some owners are not using multi-factor authentication (MFA)."
owners_header: Owners
pushed_by: Pushed by
using_mfa_info: "* All owners are using multi-factor authentication (MFA)."
using_mfa_info: "All owners are using multi-factor authentication (MFA)."
yanked_by: Yanked by
sha_256_checksum: SHA 256 checksum
signature_period: Signature validity period
Expand Down
5 changes: 1 addition & 4 deletions config/locales/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -772,10 +772,7 @@ es:
authors_header: Autores
self_no_mfa_warning_html: Considera por favor <a href="/settings/edit">activar
la autenticación de múltiples factores (AMF)</a> para mantener tu cuenta segura.
not_using_mfa_warning_show: "* Algunos propietarios no están usando AMF. Haga
click para ver la lista completa."
not_using_mfa_warning_hide: "* Los siguientes propietarios no están usando AMF.
Haga click para ocultar."
not_using_mfa_warning: "* Algunos propietarios no están usando AMF."
owners_header: Propietarios
pushed_by: Subida por
using_mfa_info: "* Todos los propietarios están usando AMF."
Expand Down
3 changes: 1 addition & 2 deletions config/locales/fr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -697,8 +697,7 @@ fr:
gem_members:
authors_header: Auteurs
self_no_mfa_warning_html:
not_using_mfa_warning_show:
not_using_mfa_warning_hide:
not_using_mfa_warning:
owners_header: Propriétaires
pushed_by:
using_mfa_info:
Expand Down
3 changes: 1 addition & 2 deletions config/locales/ja.yml
Original file line number Diff line number Diff line change
Expand Up @@ -667,8 +667,7 @@ ja:
authors_header: 作者
self_no_mfa_warning_html: アカウントをセキュアに保つため、<a href="/settings/edit">多要素認証 (MFA)
の有効化</a>をご検討ください。
not_using_mfa_warning_show: 多要素認証 (MFA) を使っていない所有者がいます。完全な一覧を見るにはクリックしてください。
not_using_mfa_warning_hide: "* 以下の所有者は多要素認証 (MFA) を使っていません。クリックして隠します。"
not_using_mfa_warning: 多要素認証 (MFA) を使っていない所有者がいます。
owners_header: 所有者
pushed_by: プッシュ者
using_mfa_info: "* 全ての所有者が多要素認証 (MFA) を使っています。"
Expand Down
3 changes: 1 addition & 2 deletions config/locales/nl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,7 @@ nl:
gem_members:
authors_header:
self_no_mfa_warning_html:
not_using_mfa_warning_show:
not_using_mfa_warning_hide:
not_using_mfa_warning:
owners_header: Eigenaren
pushed_by:
using_mfa_info:
Expand Down
5 changes: 1 addition & 4 deletions config/locales/pt-BR.yml
Original file line number Diff line number Diff line change
Expand Up @@ -676,10 +676,7 @@ pt-BR:
gem_members:
authors_header: Autores
self_no_mfa_warning_html:
not_using_mfa_warning_show: "* Alguns donos não estão usando MFA. Clique para
a lista completa."
not_using_mfa_warning_hide: "* Os seguintes donos não estão usando MFA. Clique
para esconder."
not_using_mfa_warning: "* Alguns donos não estão usando MFA."
owners_header: Donos
pushed_by:
using_mfa_info: "* Todos os donos estão usando MFA."
Expand Down
3 changes: 1 addition & 2 deletions config/locales/zh-CN.yml
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,7 @@ zh-CN:
gem_members:
authors_header: 作者
self_no_mfa_warning_html: 请考虑 <a href="/settings/edit">启用多因素身份验证(MFA)</a> 来保障您的帐户安全。
not_using_mfa_warning_show: "* 一些业主当前还没有使用多因素验证(MFA)。请点击查看完整列表。"
not_using_mfa_warning_hide: "* 以下业主还未使用多因素验证(MFA)。点击隐藏。"
not_using_mfa_warning: "* 一些业主当前还没有使用多因素验证(MFA)。"
owners_header: 业主
pushed_by: 推送
using_mfa_info: "* 所有业主都已使用多因素验证(MFA)。"
Expand Down
3 changes: 1 addition & 2 deletions config/locales/zh-TW.yml
Original file line number Diff line number Diff line change
Expand Up @@ -667,8 +667,7 @@ zh-TW:
gem_members:
authors_header: 作者
self_no_mfa_warning_html:
not_using_mfa_warning_show: "* 某些擁有者未使用多重要素驗證 (MFA)。點擊此處以顯示完整名單。"
not_using_mfa_warning_hide: "* 下列擁有者未使用多重要素驗證 (MFA)。點擊此處以隱藏。"
not_using_mfa_warning: "* 某些擁有者未使用多重要素驗證 (MFA)。"
owners_header: 擁有者
pushed_by: 推送者
using_mfa_info: "* 擁有者皆使用多重要素驗證 (MFA)。"
Expand Down

0 comments on commit 1d13ba7

Please sign in to comment.