Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing spec on ruby 3.3 #401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix failing spec on ruby 3.3 #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/gemstash/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

# :nodoc:
module Gemstash
VERSION = "2.7.1"
VERSION = "2.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something needed to make the test pass?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but I was going to cut a new version once main is green

end
7 changes: 2 additions & 5 deletions spec/integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,18 +152,15 @@
end

it "finds private gems when just the private source is configured", db_transaction: false do
skip "this doesn't work because Rubygems sends /specs.4.8.gz instead of /private/specs.4.8.gz"
env = { "HOME" => env_dir }
expect(execute("gem", ["source", "-r", "https://rubygems.org/"], env: env)).to exit_success
expect(execute("gem", ["source", "-a", host], env: env)).to exit_success
expect(execute("gem", ["source", "-r", "https://rubygems.org/", "-a", host], env: env)).to exit_success
expect(execute("gem", ["search", "-ar", "speaker"], env: env)).
to exit_success.and_output(/speaker \(0.1.0\)/)
end

it "finds private gems when just the private source is configured with a trailing slash", db_transaction: false do
env = { "HOME" => env_dir }
expect(execute("gem", ["source", "-r", "https://rubygems.org/"], env: env)).to exit_success
expect(execute("gem", ["source", "-a", "#{host}/"], env: env)).to exit_success
expect(execute("gem", ["source", "-r", "https://rubygems.org/", "-a", "#{host}/"], env: env)).to exit_success
expect(execute("gem", ["search", "-ar", "speaker"], env: env)).
to exit_success.and_output(/speaker \(0.1.0\)/)
end
Expand Down
Loading