-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/v1/versions endpoint #277
Open
micheelengronne
wants to merge
7
commits into
rubygems:main
Choose a base branch
from
micheelengronne:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
95add78
api/v1/versions endpoint
micheelengronne 22b4739
minimal versions endpoint
micheelengronne ed1356d
tests added
micheelengronne eb619cd
more explicit parameters
micheelengronne a853fe9
missing end
micheelengronne 0a2c49e
useless variables
micheelengronne 724103a
Merge branch 'main' into patch-1
olleolleolle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -201,6 +201,63 @@ def for(server_url, timeout = 20) | |||||
end | ||||||
end | ||||||
|
||||||
context "GET /api/v1/versions/:name" do | ||||||
context "from the default upstream" do | ||||||
let(:current_env) { Gemstash::Env.current } | ||||||
let(:upstream) { Gemstash::Upstream.new(current_env.config[:rubygems_url]) } | ||||||
let(:storage) { Gemstash::LocalStorage.for("gem_cache").for(upstream.host_id) } | ||||||
|
||||||
it "fetches the gem informations as json" do | ||||||
result = [{ | ||||||
"number" => "1.0.0", | ||||||
"platform" => "ruby" | ||||||
}] | ||||||
|
||||||
get "/api/v1/versions/rack.json", {}, rack_env | ||||||
expect(last_response).to be_ok | ||||||
expect(JSON.parse(last_response.body)).to eq(result) | ||||||
end | ||||||
|
||||||
it "can be called multiple times without error" do | ||||||
get "/api/v1/versions/rack.json", {}, rack_env | ||||||
get "/api/v1/versions/rack.json", {}, rack_env | ||||||
end | ||||||
end | ||||||
|
||||||
context "from private gems" do | ||||||
let(:gem_source) { Gemstash::GemSource::PrivateSource } | ||||||
let(:storage) { Gemstash::LocalStorage.for("private").for("gems") } | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
context "with a missing gem" do | ||||||
it "halts with 404" do | ||||||
get "/api/v1/versions/unknown.json", {}, rack_env | ||||||
expect(last_response).to_not be_ok | ||||||
expect(last_response.status).to eq(404) | ||||||
expect(last_response.body).to match(/not found/i) | ||||||
end | ||||||
end | ||||||
|
||||||
context "with a regular gem" do | ||||||
before do | ||||||
gem_id = insert_rubygem "example" | ||||||
insert_version gem_id, "0.1.0" | ||||||
storage.resource("example-0.1.0").save({ gem: "Example gem content" }, indexed: true) | ||||||
end | ||||||
|
||||||
it "fetches the gem informations as json" do | ||||||
result = [{ | ||||||
"number" => "0.1.0", | ||||||
"platform" => "ruby" | ||||||
}] | ||||||
|
||||||
get "/api/v1/versions/example.json", {}, rack_env | ||||||
expect(last_response).to be_ok | ||||||
expect(JSON.parse(last_response.body)).to eq(result) | ||||||
end | ||||||
end | ||||||
end | ||||||
end | ||||||
|
||||||
context "GET /gems/:id" do | ||||||
context "from the default upstream" do | ||||||
let(:current_env) { Gemstash::Env.current } | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can become