Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bundler 2.4 to documentation #991

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Add Bundler 2.4 to documentation #991

merged 1 commit into from
Dec 29, 2022

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user problem that led to this PR?

The problem was that I want to hold just a bit on publish the blog post, but that shouldn't block publishing documentation pages for Bundler 2.4.

What was your diagnosis of the problem?

My diagnosis was that we should extract documentation from #978.

What is your fix for the problem, implemented in this PR?

My fix extract documentation to this PR. Include a bare "What's new page" with just a link to the changelog for now.

Why did you choose this fix out of the possible options?

I chose this fix because it unblocks @tnir :)

No blog post for now and just a link to the changelog in the What's new
page.
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--ixplef December 29, 2022 10:47 Inactive
@deivid-rodriguez
Copy link
Member Author

Review apps seem no longer working, but I don't see any errors. Did you noticed the same @tnir?

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-bundler-2--pocabk December 29, 2022 11:28 Inactive
@tnir tnir self-requested a review December 29, 2022 11:33
Copy link
Collaborator

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New pages look good to me:
https://bundler-site-bundler-2--pocabk.herokuapp.com/v2.4/docs.html
https://bundler-site-bundler-2--pocabk.herokuapp.com/v2.4/whats_new.html

It looks like https://bundler-site-bundler-2--pocabk.herokuapp.com/ has no regression:
bundler-site-bundler-2--pocabk herokuapp com_

@tnir tnir added this to the Bundler 2.4 milestone Dec 29, 2022
@tnir tnir added the architecture/maintenance Daily architecture update label Dec 29, 2022
@tnir
Copy link
Collaborator

tnir commented Dec 29, 2022

@deivid-rodriguez Thanks for unblocking me 😁

Review apps seem no longer working, but I don't see any errors. Did you noticed the same @tnir?

Did you mean automation of review apps for PRs? I did not see any failure on automation of review apps for PRs. Or do you mean there is something wrong in the built pages? Neither, did I it.

@deivid-rodriguez
Copy link
Member Author

This is what I see when I click on the review app 🤷‍♂️

Captura de pantalla 2022-12-29 a las 12 39 34

Anyways, merging this!

@deivid-rodriguez deivid-rodriguez merged commit 7522c84 into master Dec 29, 2022
@deivid-rodriguez deivid-rodriguez deleted the bundler-2-4 branch December 29, 2022 11:40
@tnir
Copy link
Collaborator

tnir commented Dec 29, 2022

Finally I needed to retry 5 times to build the site for the deployment on Actions 😁
https://github.com/rubygems/bundler-site/actions/runs/3800281066

This is what I see when I click on the review app 🤷‍♂️

@deivid-rodriguez Oh, do you mean it is caused also in Heroku Review Apps by a segmentation fault from hpricot/rdiscount?

@deivid-rodriguez
Copy link
Member Author

@deivid-rodriguez Oh, do you mean it is caused also in Heroku Review Apps by a segmentation fault from hpricot/rdiscount?

No, I don't see any errors and the app looks to have been built just fine. But I can't access it for some reason 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture/maintenance Daily architecture update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants