-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bundler 2.4 to documentation #991
Conversation
No blog post for now and just a link to the changelog in the What's new page.
Review apps seem no longer working, but I don't see any errors. Did you noticed the same @tnir? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deivid-rodriguez Thanks for unblocking me 😁
Did you mean automation of review apps for PRs? I did not see any failure on automation of review apps for PRs. Or do you mean there is something wrong in the built pages? Neither, did I it. |
Finally I needed to retry 5 times to build the site for the deployment on Actions 😁
@deivid-rodriguez Oh, do you mean it is caused also in Heroku Review Apps by a segmentation fault from hpricot/rdiscount? |
No, I don't see any errors and the app looks to have been built just fine. But I can't access it for some reason 🤷♂️ |
What was the end-user problem that led to this PR?
The problem was that I want to hold just a bit on publish the blog post, but that shouldn't block publishing documentation pages for Bundler 2.4.
What was your diagnosis of the problem?
My diagnosis was that we should extract documentation from #978.
What is your fix for the problem, implemented in this PR?
My fix extract documentation to this PR. Include a bare "What's new page" with just a link to the changelog for now.
Why did you choose this fix out of the possible options?
I chose this fix because it unblocks @tnir :)