Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Migrate HAML files to Markdown files #929

Closed
wants to merge 2 commits into from
Closed

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Sep 14, 2022

What was the end-user problem that led to this PR?

See #928

What was your diagnosis of the problem?

All HAML files can be (manually) converted to Markdown.

What is your fix for the problem, implemented in this PR?

One HAML file was manually converted to Markdown.

Why did you choose this fix out of the possible options?

kramdown Markdown parser does not support for triple-backticks for multiple-line code blocks, so we need to use triple-tildes instead.

Signed-off-by: Takuya Noguchi [email protected]

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tnir-928-m-vywpug September 14, 2022 14:15 Inactive
This commit is only for keeping Git history.

Signed-off-by: Takuya Noguchi <[email protected]>
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tnir-928-m-vywpug September 15, 2022 08:56 Inactive
@indirect indirect temporarily deployed to bundler-site-tnir-928-m-n1z5iu January 4, 2023 10:51 Inactive
@tnir tnir self-assigned this Jan 6, 2023
@tnir tnir added this to the Re-architecturing H1 2023 milestone Jan 6, 2023
@tnir tnir added the architecture/legacy or broken Legacy and/or broken architecture label Jan 6, 2023
@tnir
Copy link
Collaborator Author

tnir commented Jan 6, 2023

Closing in favor of #1064 (also see #928)

@tnir tnir closed this Jan 6, 2023
@tnir tnir deleted the tnir-928-mdify branch January 6, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture/legacy or broken Legacy and/or broken architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants