Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haml 6.0.0.beta.2 does not work with middleman even 5.x #918

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Sep 13, 2022

HAML 6.x (at least haml 6.0.0.beta.2 or haml 6.0.1) does not work with middleman even 5.x (unreleased) since middleman-syntax latest (3.3.0) does not support haml 6.x (see middleman/middleman-syntax#80).

/home/runner/work/bundler-site/bundler-site/vendor/bundle/ruby/3.1.0/gems/middleman-syntax-3.3.0/lib/middleman-syntax/haml_monkey_patch.rb:4:in `<module:Haml>': Filters is not a module (TypeError)

Refs.

@tnir tnir self-assigned this Sep 13, 2022
@tnir tnir added the architecture/legacy or broken Legacy and/or broken architecture label Sep 13, 2022
@tnir tnir added this to the Architecture overhaul milestone Sep 13, 2022
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-haml-6-0-0-crsbvu September 13, 2022 00:29 Inactive
@tnir tnir added architecture/maintenance Daily architecture update and removed architecture/legacy or broken Legacy and/or broken architecture labels Sep 13, 2022
@tnir tnir mentioned this pull request Jan 1, 2023
@tnir
Copy link
Collaborator Author

tnir commented Jan 1, 2023

We should go with #928 instead of this PR 😁

@olleolleolle
Copy link
Member

@tnir Yeah, your HAML victory should be celebrated by you closing this PR! Awesome work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture/maintenance Daily architecture update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants