Replace node-sass with sass (Dart Sass)

[tnir]

What was the end-user problem that led to this PR?

node-sass (LibSass) has been deprecated.

What was your diagnosis of the problem?

sass (Dart Sass) is the active package.

We highly recommend using Dart Sass.
-- https://github.com/webpack-contrib/sass-loader/blob/997f3eb41d86dd00d5fa49c395a1aeb41573108c/README.md

What is your fix for the problem, implemented in this PR?

Replace node-sass with sass.

Why did you choose this fix out of the possible options?

webpack build (npx webpack -d source-map --progress --color) gets slow 2x times (from 1700-2000ms to 3900-4400ms on my local).

fibers package is not recommended for Node.js 16+, so I guess we cannot use it any more.

Fibers is not compatible with Node.js v16.0.0 or later. Unfortunately, v8 commit dacc2fee0f is a breaking change and workarounds are non-trivial. (see introduction to readme).
-- https://github.com/webpack-contrib/sass-loader/blob/997f3eb41d86dd00d5fa49c395a1aeb41573108c/README.md

webpack build performance on Actions

before: https://github.com/rubygems/bundler-site/runs/7360832092?check_suite_focus=true

== External: webpack 5.73.0 compiled with 3 warnings in 4336 ms

after: https://github.com/rubygems/bundler-site/runs/7361858411?check_suite_focus=true

== External: webpack 5.73.0 compiled with 3 warnings in 6209 ms

Signed-off-by: Takuya Noguchi [email protected]

[deivid-rodriguez]

@tnir Any reason for not creating PRs from the main repository? It's helpful to have review apps by default.

[tnir]

@deivid-rodriguez While I want to do so, in my Gitpod environment I cannot still have the (Write) permission to rubygems/bundler-site repo.

After you invited me to this repo, I already requested it on the following page from https://gitpod.io/new:

I thinks this is a kind of limitation from Gitpod when the Gitpod/GitHub integration per GitHub Org is not allowed:

$ git config credential.helper
/usr/bin/gp credential-helper
$ git remote -v
origin  https://github.com/rubygems/bundler-site.git (fetch)
origin  https://github.com/rubygems/bundler-site.git (push)
$ git push origin HEAD
remote: Permission to rubygems/bundler-site.git denied to tnir.
fatal: unable to access 'https://github.com/rubygems/bundler-site.git/': The requested URL returned error: 403

A workaround for it would be to use SSH key instead of HTTPS. But due to another limitation of Gitpod, I think I add the SSH key to ~/.ssh every time I restart the workspace (not sure why Gitpod resets ~ on stop/restart of the workspace).

Sorry for your inconvenience to increase your work.

[deivid-rodriguez]

Don't worry. Is there anything I can do so that you can get this fixed? Should I install gitpod on this repo?

[hsbt]

@tnir I approved to request for gitpod now.

[tnir]

I think permission is granted per user. Ask any of rubygems Org owners (I cannot see each member is Org Owner or Org Member) to allow me to use after they confirm how Gitpod integration affects the Org.

The following resources might be helpful:

• Errors working with private repos on GitHub orgs, caused by missing 3rd party access for Gitpod gitpod-io/gitpod#8076
• https://www.gitpod.io/docs/github-integration

[tnir]

@hsbt Thanks. It worked just now when I prepared #695 🎉

[deivid-rodriguez]

Looks good, thanks!