-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate guides for 1.12-1.14 to 1.15 #624
Aggregate guides for 1.12-1.14 to 1.15 #624
Conversation
@deivid-rodriguez I think we need to rescue Spanish translations (two files though) only for Bundler 1.15:
That is why we need this PR instead of squashing everything in Guides one time suggested in #628. Thoughts? |
I'm not fully sure what you mean. Is it that these two guides only exist in 1.15 or below and need to be updated? |
These two es translation exist only in 1.15, but I would say I cannot check if they are up to date and so compatible with en and pl for Bundler 2.3. That's why I think this PR is needed besides #628. |
Where are these translated pages linked from? We don't have any locale switcher or automatic language selection, so in my opinion it makes no sense to keep these translated pages, at least for now. |
Internal links for humans are not found but I am not sure if these translated pages are preferred to ones in English for Spaniards and people in Spain though 😀 |
92efdc6
to
3ba7c4b
Compare
@deivid-rodriguez As per #625 (comment), I updated this PR to align with the following discussion:
Also updated the description of the PR. |
I think they are not, to be honest. In any case, I think this PR is good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment.
d2c10fa
to
83e9456
Compare
Guides for v1.15 are the latest one compatible with Ruby 1.8 while ones for v1.16 were updated with Ruby 1.9 hash notation in PR rubygems#404. rubygems#404 Co-authored-by: David Rodríguez <[email protected]> Signed-off-by: Takuya Noguchi <[email protected]>
83e9456
to
77b35b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good start, let's do it!
Thank you. |
Does #641 unblock unifying all guides into a section not dependent on the version of Bundler? |
but
So weird... |
@deivid-rodriguez #641 could be an option but I had a different plan to avoid an extra copy 😀 |
Ok, what's your plan then? And what do you mean by "extra copy"? My idea with updating the Spanish guides (the only ones who had fallen behind) is that after that we could discard all old versions of guides and unify everything. |
What was the end-user problem that led to this PR?
Guides for older Bundler versions (v1.12-v1.14) are still available via side nav bar and via search engines.
What was your diagnosis of the problem?
There was no (significant) change in these guides until #404 (which was for guides for v1.16).
What is your fix for the problem, implemented in this PR?
All guides (in en and pl) in v1.12 through v1.14 are now redirected to v1.15 guides in each language.
This PR:
/v1.{12,13,14}/guides/{creating_gem,using_bundler_in_applications}.html
files/v1.{12,13,14}/guides/{creating_gem,using_bundler_in_applications}.html
to/v1.15/guides/{creating_gem,using_bundler_in_applications}.html
/v1.{12,13,14}/whats_new.html
with/v1.15/guides/{creating_gem,using_bundler_in_applications}.html
diff *.md between 1.12 and 1.15
$ diff -u source/localizable/v{1.12,1.15}/guides/creating_gem.en.html.md
$ diff -u source/localizable/v{1.12,1.15}/guides/using_bundler_in_applications.en.html.md
Why did you choose this fix out of the possible options?
Guides for v1.15 are the latest ones compatible with Ruby 1.8 while ones for v1.16 were updated with Ruby 1.9 hash notation in PR #404.
Signed-off-by: Takuya Noguchi [email protected]