Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace whats_new template in HAML with Markdown #1052

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jan 2, 2023

Replace whats_new template in HAML with one in Markdown.

Why Markdown over HAML

We do not need rich but slow technology like HAML just for writing release notes, indeed. GitHub Releases feature shows it enough to us.

We will get

via rake versions:create:

# What's New in v2.5

The [Bundler 2.5 announcement](/blog/2023/01/02/bundler-v2-5.html)
includes context and a more detailed explanation of the changes in this version.
This is a summary of the biggest changes. As always, a detailed list of every change is provided in
[the changelog](https://github.com/rubygems/rubygems/blob/3.5/bundler/CHANGELOG.md).

## BIG NEW THING

THE BIG NEW THING DOES COOL NEW STUFF.

Bundler 2.5 also includes:

- SMALL NEW THING FIXES A PROBLEM

<a href="https://github.com/rubygems/rubygems/blob/3.5/bundler/CHANGELOG.md" class="btn btn-primary">Full 2.5 changelog</a>

Signed-off-by: Takuya Noguchi [email protected]

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tn-mdify-w-if5mlu January 2, 2023 14:58 Inactive
@tnir tnir self-assigned this Jan 2, 2023
@tnir tnir added architecture/cleanup architecture/legacy or broken Legacy and/or broken architecture accessibility accessibility (a11y) etc. labels Jan 2, 2023
@tnir tnir added this to the Re-architecturing H1 2023 milestone Jan 2, 2023
@tnir
Copy link
Collaborator Author

tnir commented Jan 2, 2023

@indirect @deivid-rodriguez Any thoughts?

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 👍

@tnir tnir merged commit 4ad4dc5 into master Jan 3, 2023
@tnir tnir deleted the tn-mdify-whats_new-template branch January 3, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility accessibility (a11y) etc. architecture/cleanup architecture/legacy or broken Legacy and/or broken architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants