Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite guides/bundler_plugins from HAML to Markdown #1045

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jan 2, 2023

What was the end-user problem that led to this PR?

Part of #928 for source/guides/bundler_plugins.html.*

What was your diagnosis of the problem?

Use Markdown.

What is your fix for the problem, implemented in this PR?

Replaces guides/bundler_plugins from HAML to Markdown.

before after
bundler io_guides_bundler_plugins html bundler-site-tn-mdify-g-adbpap herokuapp com_guides_bundler_plugins html

Some mis-markups are fixed as well.

Why did you choose this fix out of the possible options?

Less indents make everyone happier.

Signed-off-by: Takuya Noguchi [email protected]

@tnir tnir self-assigned this Jan 2, 2023
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tn-mdify-g-adbpap January 2, 2023 12:20 Inactive
@tnir tnir added this to the Re-architecturing H1 2023 milestone Jan 2, 2023
@tnir tnir force-pushed the tn-mdify-guides/bundler_plugins branch from c6bf326 to 3c816b6 Compare January 2, 2023 12:33
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tn-mdify-g-adbpap January 2, 2023 12:33 Inactive
Copy link
Collaborator Author

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me as seen in screenshots.

@tnir tnir merged commit 395974f into master Jan 2, 2023
@tnir tnir deleted the tn-mdify-guides/bundler_plugins branch January 2, 2023 12:41
@tnir
Copy link
Collaborator Author

tnir commented Jan 2, 2023

Duplicated anchors remain for intention of the original author(s).

@olleolleolle
Copy link
Member

@tnir These are awesome, thanks for your tenacious activity!

@tnir
Copy link
Collaborator Author

tnir commented Mar 14, 2023

Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants