Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite guides/sinatra from HAML to Markdown #1025

Merged
merged 2 commits into from
Jan 1, 2023
Merged

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jan 1, 2023

What was the end-user problem that led to this PR?

Part of #928 for source/guides/sinatra.html.*

What was your diagnosis of the problem?

Source of /guides/sinatra.html can be rewritten in Markdown with HTML snippets.

What is your fix for the problem, implemented in this PR?

Replaces guides/sinatra from HAML to Markdown.

Why did you choose this fix out of the possible options?

We can squash and merge it in this PR since the content is too short 🥇

@tnir tnir self-assigned this Jan 1, 2023
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tn-mdify-g-lbkhq5 January 1, 2023 14:19 Inactive
@tnir tnir added content/cleanup accessibility accessibility (a11y) etc. labels Jan 1, 2023
@tnir tnir added this to the Removal duplication 1Q 2023 milestone Jan 1, 2023
Copy link
Collaborator Author

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the line require.*rubygems in another PR.

@tnir tnir merged commit 9c89200 into master Jan 1, 2023
@tnir tnir deleted the tn-mdify-guides/sinatra branch January 1, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility accessibility (a11y) etc. content/cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants