Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite guides/bundler_workflow from HAML to Markdown #1006

Merged
merged 2 commits into from
Jan 1, 2023

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jan 1, 2023

What was the end-user problem that led to this PR?

Part of #928 for source/guides/bundler_workflow.html.*

What was your diagnosis of the problem?

Source of /guides/bundler_workflow.html can be rewritten in Markdown with HTML snippets.

What is your fix for the problem, implemented in this PR?

Replaces guides/bundler_workflow from HAML to Markdown.

before after
bundler io_guides_bundler_workflow html bundler-site-tnir-928-g-s3vf5a herokuapp com_guides_bundler_workflow html

Why did you choose this fix out of the possible options?

Less indents are king while three backticks cannot be used (use three tildes instead 〰️ )

@tnir tnir self-assigned this Jan 1, 2023
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tnir-928-g-s3vf5a January 1, 2023 03:35 Inactive
@tnir tnir added content/cleanup design contributor experience Contributor/Maintainer experience labels Jan 1, 2023
@tnir tnir added this to the Re-architecturing H1 2023 milestone Jan 1, 2023
Copy link
Collaborator Author

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small visual changes can be observed, but we can ignore them compared with advantages of Markdown 👑.

@tnir tnir merged commit 81fbad8 into master Jan 1, 2023
@tnir tnir deleted the tnir-928-guides-bundler-workflow branch January 1, 2023 03:42
@tnir tnir mentioned this pull request Jan 1, 2023
1 task
@deivid-rodriguez
Copy link
Member

It's cool to be able to write markdown directly 👏 🤙

How do you access this guide, by the way? Are we linking to it internally or it's only accessible through organic search? Should we add it to the guides index?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants