Refactor ary_heap_free_ptr and remove ary_heap_free
#10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does the following: * `ary_heap_free_ptr` took an `ary` but it wasn't used for anything. The code that was using `ary` was removed in ruby#7942. * since removing the `ary` argument, there's less value in having a separate function for `ary_heap_free`. I deleted it in favor of calling `ary_heap_free_ptr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
ary_heap_free_ptrtook anarybut it wasn't used for anything. The code that was usingarywas removed in [Feature #19730] Remove transient heap #7942.aryargument, there's less value in having a separate function forary_heap_free. I deleted it in favor of callingary_heap_free_ptr.