Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rb_parser_dedent_string function #10535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce rb_parser_dedent_string function #10535

wants to merge 1 commit into from

Conversation

S-H-GAMELINKS
Copy link
Contributor

For reduce rb_fatal function and MEMOVE macro dependency to Universal Parser

@yui-knk
Copy link
Contributor

yui-knk commented Apr 15, 2024

Thanks for PR however this change introduces the dependency from parser to rb_parser_dedent_string. This is not heading towards the goal.

@S-H-GAMELINKS S-H-GAMELINKS force-pushed the add/rb_parser_dedent_string_func branch from 4ab589e to 27045f2 Compare April 18, 2024 03:04
@S-H-GAMELINKS
Copy link
Contributor Author

Thanks for your comment.
I changed it to use rb_parser_dedent_string in ruby_parser.c or parse.y depending on whether the UNIVERSAL_PARSER is present or not

@S-H-GAMELINKS S-H-GAMELINKS force-pushed the add/rb_parser_dedent_string_func branch from 27045f2 to 535df2d Compare April 20, 2024 19:36
@S-H-GAMELINKS
Introduce rb_parser_dedent_string function
dba13a1 
For reduce rb_fatal function and MEMOVE macro dependency to Universal Parser
@S-H-GAMELINKS S-H-GAMELINKS force-pushed the add/rb_parser_dedent_string_func branch from 535df2d to dba13a1 Compare April 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@S-H-GAMELINKS @yui-knk