Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the license of net-imap #275

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Clarify the license of net-imap #275

merged 2 commits into from
Jun 1, 2024

Conversation

shugo
Copy link
Member

@shugo shugo commented May 1, 2024

ruby/resolv#45 realized me that LICENSE.txt contains only BSD-2-Clause license, while gemspec specifies both Ruby's and BSD-2-Clause license. So I'd like to clarify the license.

ruby/resolv#45 realized me that LICENSE.txt contains only BSD-2-Clause license, while gemspec specifies both Ruby's and BSD-2-Clause license.  So I'd like to clarify the license.
hsbt
hsbt previously approved these changes May 1, 2024
@shugo
Copy link
Member Author

shugo commented May 1, 2024

Patch authors since bf0407c:

$ git shortlog -sn bf0407c..                                 
   352  nicholas a. evans
    37  Hiroshi SHIBATA
    30  Shugo Maeda
    19  dependabot[bot]
     6  Nobuyoshi Nakada
     6  Stefan Hoffmann
     5  Arnt Gulbrandsen
     3  Damir Gainetdinov
     3  Sarah Sunday
     2  Bijan Rahnema
     2  Sorah Fukumori
     2  Takashi Kokubun
     1  Debasish Biswas
     1  Kazuhiro NISHIYAMA
     1  Le Roy Christophe
     1  Mark Young
     1  Olle Jonsson
     1  Peter Goldstein
     1  Ryuta Kamizono
     1  Vít Ondruch
     1  Yusuke Endoh
     1  aycabta

@nevans @hsbt @nobu @hoffi @arnt @gaynetdinov @ssunday @gobijan @sorah @k0kubun @debasishbsws @znz @c-leroy @mark-young-atg @olleolleolle @petergoldstein @kamipo @voxik @mame @aycabta
If you object to including the Ruby's license, could you mention it here by 2024-06-01 00:00:00 UTC?
Just add a 👍 reaction, if you have no objection.

@shugo shugo requested review from nevans and nobu and removed request for nobu May 1, 2024 07:37
@arnt
Copy link
Contributor

arnt commented May 1, 2024 via email

@shugo
Copy link
Member Author

shugo commented May 1, 2024

I've fixed typo in #275 (comment): if you have any objection -> if you have no objection.

LICENSE.txt Outdated
Comment on lines 1 to 2
All the files in this distribution are covered under either the Ruby's
license (see the file COPYING) or BSD-2-Clause license (see the file BSDL)
Copy link
Member Author

@shugo shugo May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSDL is mentioned in COPYING, so the above description may be redundant.

Suggested change
All the files in this distribution are covered under either the Ruby's
license (see the file COPYING) or BSD-2-Clause license (see the file BSDL)
All the files in this distribution are covered under the Ruby's
license (see the file COPYING)

@nevans
Copy link
Collaborator

nevans commented May 1, 2024

👍🏻 Looks good to me. Thanks @shugo!

nevans
nevans previously approved these changes May 1, 2024
@sorah
Copy link
Member

sorah commented May 1, 2024

I have no objection and agree to clarify

@nevans
Copy link
Collaborator

nevans commented May 1, 2024

@shugo @hsbt I did add my "approved" PR review, but I assume we should wait until either a) 2024-06-01 00:00:00 UTC or b) we have everyone's explicit approval before merging this.

From my perspective, this was always the intended license. So I'm hopeful and expect that everyone involved will agree.

@shugo shugo dismissed stale reviews from nevans and hsbt via 23c5b75 May 2, 2024 00:11
@shugo
Copy link
Member Author

shugo commented May 2, 2024

@nevans Thanks for your confirmation.
I've removed a direct reference to BSDL in 23c5b75. Could you check it out?

I'd like to merge this PR on 2024-06-01 if there's no objection.

@shugo
Copy link
Member Author

shugo commented May 7, 2024

@nevans Could you approve this PR again if 23c5b75 looks good?

@shugo shugo requested a review from nevans May 7, 2024 07:49
@shugo shugo merged commit 21e0a91 into master Jun 1, 2024
26 checks passed
@shugo shugo deleted the clarify_license branch June 1, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants