Less aggressive async pruning for RubyThreadPoolExecutor #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
commented
Jan 17, 2025
| DEFAULT_THREAD_IDLETIMEOUT = 60 | ||
|
|
||
| # @!macro thread_pool_executor_constant_default_pool_prune_timeout | ||
| DEFAULT_POOL_PRUNETIMEOUT = 30 |
There was a problem hiding this comment.
A somewhat arbitrary number, but this is also what puma uses.
joshuay03
force-pushed
the
add-pruner-thread-to-ruby-thread-pool-executor
branch
from
b5dd976 to
6e5e003
Compare
|
Have you seen #1075? It seems quite related. |
Oh I haven't, last I checked was when I opened my issue and there wasn't anything similar. Yes this should solve that too, I'll leave a comment there. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1066
Issue script output with this patch
Adds a pruner thread to
RubyThreadPoolExecutorwith the intention of making pruning a lot less aggressive which should reduce the likelihood of prematurely scaling down the size of the pool right after being assigned a large workload.