Set rake-compiler source and target to Java 8 #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch forces rake-compiler to emit bytecode for Java 8 level of JVM. rake-compiler currently defaults to Java 1.7 source and target, but that version is no longer supported by recent JDKs such as Java 21 (see rake-compiler/rake-compiler#242 for a patch to update rake-compiler). This patch sets our minimum Java level to 8, bypassing the default in rake-compiler and allowing builds on Java 21+.
|
This can be merged and released at any time. Without this, it is not possible to build the concurrent-ruby extension for JRuby on Java 21 or higher. |
|
Small correction: this does not require immediate release. Merging to the repository fixes issues in JRuby 10's CI which runs a minimum of Java 21. Once released, all extensions will be Java 8 minimum, but I believe the current 1.7 extensions can still load on Java 21 (it just can't output 1.7 bytecode). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch forces rake-compiler to emit bytecode for Java 8 level of JVM. rake-compiler currently defaults to Java 1.7 source and target, but that version is no longer supported by recent JDKs such as Java 21 (see rake-compiler/rake-compiler#242 for a patch to update rake-compiler).
This patch sets our minimum Java level to 8, bypassing the default in rake-compiler and allowing builds on Java 21+.