Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also suggest rubocop-rspec for those using rspec-rails #12908

Merged
merged 4 commits into from
May 17, 2024

Conversation

pirj
Copy link
Member

@pirj pirj commented May 16, 2024

rubocop-rspec_rails provides rspec-rails specific cops, but generic rspec cops still apply, as rspec-rails depends on rspec (core, expectations and mocks)

This partially reverts #12813

Also see rubocop/rubocop-rspec_rails#28


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

pirj added 4 commits May 16, 2024 20:07
rubocop-rspec_rails provides rspec-rails specific cops, but generic rspec cops still apply, as rspec-rails depends on rspec (core, expectations and mocks)
@pirj
Copy link
Member Author

pirj commented May 16, 2024

Cc @ydah @bquorning

@pirj pirj marked this pull request as ready for review May 16, 2024 17:35
Copy link
Contributor

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 but of course squash it into 1 commit.

@bbatsov bbatsov merged commit 673495b into rubocop:master May 17, 2024
34 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented May 17, 2024

I've squashed the commits myself. Thanks!

@pirj pirj deleted the patch-1 branch May 17, 2024 05:26
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants