Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Don't advertise support for Pull Diagnostics #12906

Merged
merged 1 commit into from
May 16, 2024

Conversation

koic
Copy link
Member

@koic koic commented May 16, 2024

Follow up standardrb/standard#627.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit 47ee67c into rubocop:master May 16, 2024
33 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented May 16, 2024

Thanks! I guess we should also add some ticket to look into adding support for pull diagnostics in the future if those are better than push diagnostics.

@koic koic deleted the standard_627 branch May 16, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants