Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run actions on 2-x-stable branch #1895

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Run actions on 2-x-stable branch #1895

merged 2 commits into from
Jun 3, 2024

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Jun 2, 2024 •
edited
Loading

Our (CI and gem-publish) workflows on the master branch are configured to run when changes happen to on master branch. For the same workflows to run on changes to the 2-x-stable branch, we need to reconfigure the workflow triggers. (Note that the workflows are unchanged on master, so they will now trigger on both branches).

@bquorning bquorning marked this pull request as ready for review June 2, 2024 14:48
@bquorning bquorning requested a review from a team as a code owner June 2, 2024 14:48
@bquorning
Configure GHA workflows for the 2-x-stable branch
9efc2ad 
It seems that the configurations

    on:
      - pull_request

and

    on:
      pull_request:

will only trigger a workflow run when the target branch is the repo's
default branch (but I could not find any documentation for it). Let's
see if an explicit branch name will make workflows run for our PRs.
@bquorning
fixup! Configure GHA workflows for the 2-x-stable branch
5cf9381
@bquorning bquorning force-pushed the run-actions-on-2-x-stable-branch branch from 3960ac5 to 5cf9381 Compare June 2, 2024 15:02
@bquorning bquorning changed the title Run actions on 2 x stable branch Run actions on 2-x-stable branch Jun 2, 2024
@pirj
Copy link
Member

pirj commented Jun 2, 2024

I’m sorry, I’m lost. What is the 2-x-stable for?

@bquorning
Copy link
Collaborator Author

I’m sorry, I’m lost. What is the 2-x-stable for?

I saw your comment #1894 (comment), but just in case anyone else are lost:

My apologies, I probably have never properly explained it. My idea with having a 2-x-stable branch was to keep making v2.x releases of rubocop-rspec while we are using master branch to prepare the v3 release. Some of the changes that go into master can be backported to 2-x-stable, and I think especially new cops should be backported. This ensures that we can get feedback on their use before we release v3. If we don’t solicit such feedback, we can hardly make those new cops enabled, but would keep them as pending until v4 some time in the future.

ydah
ydah approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bquorning bquorning merged commit 5dea642 into 2-x-stable Jun 3, 2024
24 checks passed
@bquorning bquorning deleted the run-actions-on-2-x-stable-branch branch June 3, 2024 05:30
@bquorning
Copy link
Collaborator Author

🤦🏼 I forgot to squash before merging. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bquorning @pirj @ydah