Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive RSpec/Focus when chained method call and inside define method #1704

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Sep 4, 2023

Fix: #398


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

spec/rubocop/cop/rspec/focus_spec.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydah

@bquorning bquorning merged commit 86a1f33 into master Sep 4, 2023
22 checks passed
@bquorning bquorning deleted the fix/398 branch September 4, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus cop raises incorrectly on variables named fit.
2 participants