Obsolete StringAsInstanceDoubleConstant in favor of VerifiedDoubleRef…

…erence for constants only

.rubocop.yml

@@ -250,8 +250,3 @@ Style/StringChars: {Enabled: true}
 Style/SuperWithArgsParentheses: {Enabled: true}
 Style/SwapValues: {Enabled: true}
 Style/YAMLFileRead: {Enabled: true}
-
-# Enable our own pending cops.
-#
-RSpec/StringAsInstanceDoubleConstant:
-  Enabled: true

CHANGELOG.md

@@ -9,6 +9,7 @@
 - Fix `RSpec/VoidExpect` to only operate inside an example block. ([@corsonknowles])
 - Change `RSpec/ContextWording` cop to always report an offense when both `Prefixes` and `AllowedPatterns` are empty. ([@ydah])
 - Add support for `and` and `or` compound matchers to `RSpec/ChangeByZero` cop. ([@ydah])
+- Replace `RSpec/StringAsInstanceDoubleConstant` with `RSpecVerifiedDoubleReference` configured to only support constant class references. ([@corsonknowles])
 
 ## 3.1.0 (2024-10-01)
 

config/default.yml

@@ -930,13 +930,6 @@ RSpec/SpecFilePathSuffix:
     - "**/spec/**/*"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SpecFilePathSuffix
 
-RSpec/StringAsInstanceDoubleConstant:
-  Description: Do not use a string as `instance_double` constant.
-  Enabled: pending
-  Safe: false
-  VersionAdded: '3.1'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/StringAsInstanceDoubleConstant
-
 RSpec/StubbedMock:
   Description: Checks that message expectations do not have a configured response.
   Enabled: true
@@ -995,12 +988,8 @@ RSpec/VerifiedDoubleReference:
   Description: Checks for consistent verified double reference style.
   Enabled: true
   SafeAutoCorrect: false
-  EnforcedStyle: constant
-  SupportedStyles:
-    - constant
-    - string
   VersionAdded: 2.10.0
-  VersionChanged: '2.12'
+  VersionChanged: "<<next>>"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubleReference
 
 RSpec/VerifiedDoubles:

config/obsoletion.yml

@@ -28,3 +28,6 @@ extracted:
   RSpec/Rails/*: rubocop-rspec_rails
   RSpec/FactoryBot/*: rubocop-factory_bot
   RSpec/Capybara/*: rubocop-capybara
+
+renamed:
+  RSpec/StringAsInstanceDoubleConstant: RSpec/VerifiedDoubleReference

docs/modules/ROOT/pages/cops.adoc

@@ -101,7 +101,6 @@
 * xref:cops_rspec.adoc#rspecsortmetadata[RSpec/SortMetadata]
 * xref:cops_rspec.adoc#rspecspecfilepathformat[RSpec/SpecFilePathFormat]
 * xref:cops_rspec.adoc#rspecspecfilepathsuffix[RSpec/SpecFilePathSuffix]
-* xref:cops_rspec.adoc#rspecstringasinstancedoubleconstant[RSpec/StringAsInstanceDoubleConstant]
 * xref:cops_rspec.adoc#rspecstubbedmock[RSpec/StubbedMock]
 * xref:cops_rspec.adoc#rspecsubjectdeclaration[RSpec/SubjectDeclaration]
 * xref:cops_rspec.adoc#rspecsubjectstub[RSpec/SubjectStub]