Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker container and a serve.py app to serve the generate static files. #19

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tobiashochguertel
Copy link

Adds Dockerfile and Compose file to the project.
Adds a simple static file html server via fastapi and uvicorn.

I pushed a Docker-image to Docker Hub (arm64, amd64): https://hub.docker.com/r/tobiashochguertel/koala-keys
the Docker-image generate the static html pages and then starts the simple html server to serve the generate content. Have a look into docker-compose.yaml.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, filesystem, network, shell 0 3.93 MB tiangolo
pypi/[email protected] Transitive: environment, eval, filesystem, network, shell +2 1.28 MB

View full report↗︎

@rtuszik
Copy link
Owner

rtuszik commented Nov 4, 2024

I appreciate the PR! Have been thinking about this for some time now.

Two points:

  1. I want to avoid making people download dependencies that they don't use if they only want to use the HTML files. Maybe a separate requirements-serve.txt?

  2. I would prefer having the image built in a workflow. Something like this.
    That lets us avoid the additional scripts and keeps it up to date.

Open to hear your thoughts on this!

Cheers.

@rtuszik rtuszik added the enhancement New feature or request label Nov 4, 2024
@modem7 modem7 mentioned this pull request Nov 4, 2024
@tobiashochguertel
Copy link
Author

thanks for the feedback. The points make sense to me, I will update the pull request.

@rtuszik rtuszik changed the base branch from main to develop November 9, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants