Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve compatibility issue with PHP 8.1 #157

Closed

Conversation

Utsav-Ladani
Copy link
Collaborator

Description

  • This PR resolves the compatibility issue with PHP 8.1
  • The FILTER_SANITIZE_STRING is deprecated in [email protected], so it is replaced with FILTER_SANITIZE_FULL_SPECIAL_CHARS which works same according to PHP docs.

Related issue

@milindmore22 milindmore22 requested a review from abhishekfdd June 9, 2023 11:25
Copy link
Contributor

@abhishekfdd abhishekfdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Utsav-Ladani Fix failed checks

@Utsav-Ladani
Copy link
Collaborator Author

@Utsav-Ladani Fix failed checks

Hello @abhishekfdd

I tried, but some TOKEN error prevents inspections. Can you please look into it?

Thanks

@Utsav-Ladani Utsav-Ladani requested a review from abhishekfdd June 9, 2023 12:43
@rtBot
Copy link
Contributor

rtBot commented Jun 12, 2023

Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:

  • src/Modules/Login.php
  • src/Modules/OneTapLogin.php
  • src/Utils/Helper.php

The error may be temporary. If the error persists, please contact a human (commit-ID: a09ef68).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants