Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Panel, Tree, CheckTree): add support for scrollShadow #3818

Merged
merged 5 commits into from
May 24, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented May 23, 2024

Scroll shadows are such nice UX. When a container is scrolled down, you can see a shadow at the top, which makes it clear you can scroll back up. And if it’s possible to scroll down, there is a shadow down there also, unless you’ve scrolled down all the way.

https://rsuite-nextjs-git-feat-panel-scroll-shadow-rsuite.vercel.app/components/panel/#scroll-shadows

<Panel scrollShadow >
...
</Panel>

Copy link

codesandbox bot commented May 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 9:13am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 9:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:13am

Copy link

codesandbox-ci bot commented May 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 95.48387% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 94.25%. Comparing base (5f3d1a1) to head (da03afb).

Files Patch % Lines
src/internals/ScrollView/hooks/useScrollState.ts 86.20% 3 Missing and 1 partial ⚠️
src/Panel/Panel.tsx 83.33% 0 Missing and 1 partial ⚠️
src/Panel/hooks/useExpanded.ts 93.33% 0 Missing and 1 partial ⚠️
src/internals/Windowing/List.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3818    +/-   ##
========================================
  Coverage   94.24%   94.25%            
========================================
  Files         709      715     +6     
  Lines       23312    23413   +101     
  Branches     3106     3119    +13     
========================================
+ Hits        21971    22067    +96     
- Misses        672      675     +3     
- Partials      669      671     +2     
Flag Coverage Δ
ChromeCi 94.20% <95.48%> (+<0.01%) ⬆️
Firefox 93.68% <95.48%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo changed the title feat(Panel): add support for scrollShadow feat(Panel, Tree, CheckTree): add support for scrollShadow May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant