fix(Rating): fix issue with state snapshots and therefore provide decent support for mobile phones #2945
+53
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding issue can be found here: #2917
The problem was the following: 2 functions operating on the same state were wrapped within 1 parent function -> one of them setting a state, the other one reading the state. The reading function was expecting to get the new value from the state, set by the previous function. As react operates on snapshots, the reading function retrieved the old value instead of the new one. I took the opportunity and tried to refactor those parts.