Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates AMS to V5 #348

Closed
wants to merge 2 commits into from
Closed

Updates AMS to V5 #348

wants to merge 2 commits into from

Conversation

eliocamp
Copy link
Contributor

@eliocamp eliocamp commented Nov 9, 2020

Following #298.
I wanted to push this only after submitting and being given the A-OK from the good people at the AMS. But now it turns out I won't be submitting to that journal, so, well, here's the updated version of the AMS article template.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2020

CLA assistant check
All committers have signed the CLA.

@cderv
Copy link
Collaborator

cderv commented Nov 12, 2020

Thanks @eliocamp ! I see there is hook you mentioned in #298. Is this a modified version of knitr::hook_plot_tex() ?

@yufree, as the original contributor, do you want to take a look at this too ?

@eliocamp
Copy link
Contributor Author

eliocamp commented Nov 12, 2020

Thanks @eliocamp ! I see there is hook you mentioned in #298. Is this a modified version of knitr::hook_plot_tex() ?

Yep. The change is that it uses appendcaption instead of caption. Is part of the instructions from the AMS template.

@yufree
Copy link
Contributor

yufree commented Nov 15, 2020

It seems the check could not pass:

! Package inputenc Error: Unicode character ≤ (U+2264)

  (inputenc)                not set up for use with LaTeX.

To solve this issue, you could change the latex engine from pdflatex to xelatex in the template to avoid the issue.

An optional plain language summary suitable for wider readership that provides additional context for why the work is relevant to science and society. It should be concise (≤120 words) and authors should follow the guidelines for significance statements (\url{https://www.ametsoc.org/index.cfm/ams/publications/authors/journal-and-bams-authors/significance-statements/}) (currently MWR,WAF, and WCAS only).
capsule: |
A short (20-30 words maximum) capsule summary of your article (for BAMS only).
bibliography: references.bib
output: rticles::ams_article
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change here to pass the check.

output: 
  rticles::ams_article:
    latex_engine: xelatex

Copy link
Collaborator

@cderv cderv Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean this format has to default to xelatex ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for this template. It seems the bib file contain unicode character which will not map to output through pdflatex. Such issue blocked the check. Since the bib file might be from ASM, we could set the default engine to xelatex to be friendly to the user.

@eliocamp
Copy link
Contributor Author

I added xelatex as latex_engine in the skeleton.

@yihui
Copy link
Member

yihui commented Dec 15, 2020

Yep. The change is that it uses appendcaption instead of caption. Is part of the instructions from the AMS template.

@eliocamp If you had to copy the 150 lines of code of hook_plot_tex from knitr, modify one line, and add to this package, I'll definitely reconsider yihui/knitr#1872, because otherwise this will be a disaster for us to maintain in rticles :)

@cderv cderv linked an issue Jun 9, 2021 that may be closed by this pull request
@cderv cderv mentioned this pull request Sep 7, 2021
@cderv
Copy link
Collaborator

cderv commented Sep 7, 2021

Sorry for the delay. V6 template for AMS is out. Should we consider V6 and abandon V5 here ?
#298 (comment)

@ConorIA ConorIA mentioned this pull request Oct 17, 2021
5 tasks
@cderv
Copy link
Collaborator

cderv commented Nov 29, 2021

I am closing this PR in favor of #444.

Thanks.

@cderv cderv closed this Nov 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated AMS template
5 participants