Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default style preview #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felipecrp
Copy link
Contributor

@felipecrp felipecrp commented Nov 13, 2021

Hi,

I noticed that creating a document using only the default.css generates a problem with the preview, as I showed in the next figure:

image

I updated the default.css with the updated code from interface.css, available at https://gitlab.pagedmedia.org/tools/interface-polyfill. The result sounds good, except that we missed some specific tags for TOC, footnotes, chapter, etc. The next figure shows the correct pages, but without "..." on TOC:

image

I could add the .toc class back to the code, but I think it would be better to keep the default.css equal with the interface.css because it would make it easier for future upgrades. My suggestion is to add the specific formats to another CSS file. That way, users may choose whether they will use a custom TOC or not.

I think it would be nice to have a clean default.css to enable other users to create their themes from scratch without worrying about pre-made styles. Another solution would be to keep the current default.css and create a new base.css with the interface.css code to enable users to design from scratch.

Another drawback of the interface.css is that it does not fit the single-page mode when previewed in a narrow (low width/res) browser.

@yihui , @cderv , and @RLesur . What do you think?

Regards,

@felipecrp
Copy link
Contributor Author

I will provide my test page in the following URL:

https://gist.github.com/felipecrp/46587c9d93fbf8206a7e33b5058f5ae2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant