Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hall_of_fame attribute such that users can retrieve the k best … #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cfusting
Copy link

…scores and parameters from a run.

@ryanpeach
Copy link
Contributor

Huh, ok. I thought for sure we had one of those. It's a little redundant since we have the entire history, logbook, best_scores and best_parameters returned, but if you want the deap native implementation I don't have a problem with it. Please duplicate all your work with the maximize function on the optimize.py file, and make sure it passes (or else change) the test.py script, and your good.

@ryanpeach
Copy link
Contributor

if you have to add another output to maximize, please change it so that it returns an extra dict instead so we can start simply naming additional new outputs.

@cfusting
Copy link
Author

I felt like using the other objects to retrieve the hall of fame was a bit circuitous. I'll add the item to maximize.

@cfusting
Copy link
Author

This is all ready to go.

@rsteca
Copy link
Owner

rsteca commented Oct 21, 2017

Can you fix the conflicts so I can merge this? Thanks for the pull request!

@cfusting
Copy link
Author

I resolved these as best I could but I think another commit occurred around the same time as mine. Perhaps we should have the other merger have a look over my resolutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants