Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashes on X=None #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crashes on X=None #21

wants to merge 1 commit into from

Conversation

kootenpv
Copy link
Contributor

@kootenpv kootenpv commented Apr 9, 2017

No description provided.

@ryanpeach
Copy link
Contributor

Shouldn't it? Also, see my most recent pull request for a maximize without data needed.

@kootenpv
Copy link
Contributor Author

My apologies for the bad naming. I meant "it currently crashes complaining X=None". When I give X to the check_cv function, it stops crashing. How could you do cross validation without X? It just looks like you forgot to pass X to check_cv

@ryanpeach
Copy link
Contributor

Hm, I never encountered that error, could you highlight the issue in code?

My "maximize" function is more similar to a scipy.optimize format than a sklearn format, no CV. However, it uses the same logic as the original code, and my hope is the sklearn estimator can use the maximize function to prevent code duplication. Sometimes, you just need to optimize a function's output based on parameters, other times you need to train a learner on data, but those two problems have an intersection with the same evolutionary parameter_grid search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants