Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a diff for comparisons of arrays of one-line strings #597

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Show a diff for comparisons of arrays of one-line strings #597

wants to merge 2 commits into from

Commits on May 9, 2024

  1. Add tests checking handling of single-line string arrays 

    (as described in rspec-expectations/rspec#415)
    @nevinera
    nevinera committed May 9, 2024
    Configuration menu
    Copy the full SHA
    63f2e2c View commit details
    Browse the repository at this point in the history

  2. Update Differ to handle arrays of single-line strings 

    (instead of skipping them). This behavior was originally added in in
rspec-expectations commit 044b0a6, as part of
rspec/rspec-expectations#115, which was
intended to `expect("a").to eq("b")` from showing an extra diff, when
the error message already showed the whole diff (so the diff itself was
kind of unnecessary). There are tests already enforcing _that_, so we
don't need to add any, but this change retains that behavior (though
single-element single-line array comparisons do now get a diff).
    @nevinera
    nevinera committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9a4b0be View commit details
    Browse the repository at this point in the history