This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Raise ArgumentError when doc_string is neither string nor nil #3081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: rspec/rspec#40
To keep the first argument a string object, it raises ArgumentError when non string object were given as doc_string.
Currently example recognize its first argument as doc_string even if it is not a string object.
For example,
In the example above,
:pending
does not work and fails like belowI suppose that if this PR is beneficial for RSpec, this breaking change will be released for upcoming new major version 4.0 or later. For preparing the change I created another PR #3073 to output deprecation warning in the same condition.