Create a utility method to remove signatures from a bitcoin transaction #2728
+168
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia-zack
approved these changes
Sep 13, 2024
nathanieliov
approved these changes
Sep 16, 2024
Rename variables Modify method to just remove signatures from non-segwit transactions Modify message from thrown exception to be more accurate Add indentation to improve readability
Remove unnecessary import resolve comments
… inputs or without inputs with p2sh multisig script sig. Rename. Reorder blank lines Rename scriptSig to inputScript Set network parameters at bridge support class level to avoid duplication code
…of updateScriptWithSignature Add [methodName] when logging. Use getSigInsertionIndex to make method more realistic. Remove error being thrown when tx has no inputs. Remove unused import
…ve methods naming Fix wrong log
marcos-iov
force-pushed
the
remove-signatures
branch
from
88f01ac
to
16d8a99
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: